-
Notifications
You must be signed in to change notification settings - Fork 3.1k
fix: Transparent ExpandableCalendar #2653
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
- Introduced a ref to conditionally measure header height only when necessary. - Updated onHeaderLayout to prevent unnecessary state updates. - Adjusted onLayout prop for Animated.View to utilize the new measurement logic.
Hi @freely322 , |
@nitzanyiz @Inbal-Tish @ethanshar Take a look please |
Here's a patch for this fix.
|
Wow, this is a painful bug that wasted a bunch of time... When will this be merged in? I manually patched. |
+1 the above fixed for me... only thing that I had to change was that I always had to add So, pretty much what @ajp8164 had but with +5... so looks like this
|
Will also fix #2722 |
@Inbal-Tish @nitzanyiz - please have a look at this PR 🙏🏽 |
@ethanshar @Inbal-Tish @nitzanyiz can you take a look at this? |
also having this issue, @ethanshar @Inbal-Tish @nitzanyiz will anyone take a look at this? |
I'm migrating to expo v54 + react native v0.81 and this issue is back even after applying the patch #2653 (comment) Did anyone managed to solve this issue? If so, how? |
Not me, I had to roll back to v1.1289.0 |
The issue related to dynamic headerHeight was not set.
Related issues:
#2625
#2693
#2681
#2670
#2657
#2571
#2722